Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14953 )
Change subject: [tests] address flakiness in raft_consensus_election-itest ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14953/1/src/kudu/integration-tests/raft_consensus_election-itest.cc File src/kudu/integration-tests/raft_consensus_election-itest.cc: http://gerrit.cloudera.org:8080/#/c/14953/1/src/kudu/integration-tests/raft_consensus_election-itest.cc@129 PS1, Line 129: workload->set_write_timeout_millis((AllowSlowTests() ? 120 : 60) * 1000); > Hmm, why condition this on slow tests and not something like build type? AF Yes, I agree -- this looks strange. Actually, this mirrors the logic of the call sites passing 'max_rows_to_insert': that depends on AllowSlowTests(). I think I'll better change the signature of the DoTestChurnyElections() function to make it more consistent. -- To view, visit http://gerrit.cloudera.org:8080/14953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6f54643c9c066b31a74e1082260225e60324e4e Gerrit-Change-Number: 14953 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 30 Dec 2019 08:17:24 +0000 Gerrit-HasComments: Yes
