Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14954 )
Change subject: [consensus] short-circuit response path for RequestVote() ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14954/3/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/14954/3/src/kudu/consensus/raft_consensus.cc@198 PS3, Line 198: DCHECK(std::atomic_is_lock_free(&withhold_votes_until_)); > Per this C++ reference, std::atomic<> might be implemented not via lock-fre Yeah I think dropping it is fine. Even on other architectures, this will be implemented with a lock, so it's not like it'd be unsafe; it'd just be less performant. -- To view, visit http://gerrit.cloudera.org:8080/14954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67efef72b74ce243ca060e89fcec6eb11e95e8e8 Gerrit-Change-Number: 14954 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 30 Dec 2019 18:45:06 +0000 Gerrit-HasComments: Yes
