Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14945 )
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/14945/5/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/14945/5/src/kudu/tserver/tablet_server-test.cc@2712 PS5, Line 2712: // only few schema : SchemaBuilder sb(schema_); : // Remove key column and next column from the projection. Nit: maybe replace these two comments with "Set up a projection without the key columns or the column after the last key column." http://gerrit.cloudera.org:8080/#/c/14945/5/src/kudu/tserver/tablet_server-test.cc@2743 PS5, Line 2743: // Drain all the rows from the scanner. If you can call ScannerManager::ListScans, you can test that the iterator stats include the correct columns. -- To view, visit http://gerrit.cloudera.org:8080/14945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31 Gerrit-Change-Number: 14945 Gerrit-PatchSet: 5 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Sat, 04 Jan 2020 22:30:07 +0000 Gerrit-HasComments: Yes
