Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14426 )
Change subject: KUDU-2791 p2: add basic protobuf msg ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/14426/4/src/kudu/subprocess/subprocess.proto File src/kudu/subprocess/subprocess.proto: http://gerrit.cloudera.org:8080/#/c/14426/4/src/kudu/subprocess/subprocess.proto@17 PS4, Line 17: syntax = "proto2"; nit: does it make sense to add a small comment pointing to the fact that this protobuf definition file actually requires protobuf3 despite using protobuf2 syntax? http://gerrit.cloudera.org:8080/#/c/14426/4/src/kudu/subprocess/subprocess.proto@25 PS4, Line 25: message EchoRequestPB { : required string data = 1; : } : message EchoResponsePB { : required string data = 1; : } Do you mind adding a small comment for these (something like in the commit description)? -- To view, visit http://gerrit.cloudera.org:8080/14426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954 Gerrit-Change-Number: 14426 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 Jan 2020 20:07:58 +0000 Gerrit-HasComments: Yes
