Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14986 )
Change subject: KUDU-3011 p3: mechanism to quiesce scans ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/14986/4/src/kudu/integration-tests/tablet_server_quiescing-itest.cc File src/kudu/integration-tests/tablet_server_quiescing-itest.cc: http://gerrit.cloudera.org:8080/#/c/14986/4/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@381 PS4, Line 381: ASSERT_OK(scanner.NextBatch(&batch)); Does it make sense to add a test case to verify that ScannerKeepAlive RPC works fine on a quiescent tablet server? http://gerrit.cloudera.org:8080/#/c/14986/4/src/kudu/integration-tests/test_workload.h File src/kudu/integration-tests/test_workload.h: http://gerrit.cloudera.org:8080/#/c/14986/4/src/kudu/integration-tests/test_workload.h@131 PS4, Line 131: This sort of error nit: what error? http://gerrit.cloudera.org:8080/#/c/14986/4/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/14986/4/src/kudu/tserver/tablet_service.cc@362 PS4, Line 362: CheckTabletServerQuiescingOrRespond nit: looks like a misnomer: the behavior of this method hints it should have been called CheckTabletServerNotQuiescingOrRespond(). -- To view, visit http://gerrit.cloudera.org:8080/14986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idedca29f40b0a8576245be0f7cfad2be29db4135 Gerrit-Change-Number: 14986 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 08 Jan 2020 02:57:13 +0000 Gerrit-HasComments: Yes
