Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14984 )
Change subject: KUDU-3005: Reduce size of kudu-python docker image ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14984/2/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/14984/2/docker/Dockerfile@66 PS2, Line 66: RUN ./bootstrap-dev-env.sh \ : && ./bootstrap-python-env.sh \ : && rm bootstrap-dev-env.sh \ : && rm bootstrap-python-env.sh > IIUC each COPY/RUN/etc statement affects the checkpoints that docker create What Andrew said. Each RUN command creates a layer in the docker image and each layer is additional size which we don't want or need. The only time layers are useful is for incremental building. http://gerrit.cloudera.org:8080/#/c/14984/2/docker/Dockerfile@256 PS2, Line 256: python > Python Done http://gerrit.cloudera.org:8080/#/c/14984/2/docker/bootstrap-python-env.sh File docker/bootstrap-python-env.sh: PS2: > Given how this is used (copying into the docker container and then run), I Oh, I intended to remove the python stuff from the dev file. I will do that now. -- To view, visit http://gerrit.cloudera.org:8080/14984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I159907c4a85e919d98c92df97cd44d0300d1cd29 Gerrit-Change-Number: 14984 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 09 Jan 2020 19:56:43 +0000 Gerrit-HasComments: Yes
