Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15005 )
Change subject: clock: remove shared ownership ...................................................................... Patch Set 3: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/15005/3/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/15005/3/src/kudu/tablet/tablet.h@69 PS3, Line 69: } // namespace clock Nit: kind of weird placement? http://gerrit.cloudera.org:8080/#/c/15005/3/src/kudu/tablet/tablet.h@75 PS3, Line 75: } Nit: while you're here, add a namespace comment? http://gerrit.cloudera.org:8080/#/c/15005/3/src/kudu/tablet/tablet_bootstrap-test.cc File src/kudu/tablet/tablet_bootstrap-test.cc: http://gerrit.cloudera.org:8080/#/c/15005/3/src/kudu/tablet/tablet_bootstrap-test.cc@82 PS3, Line 82: class LogicalClock; Nit: maybe move this into the existing kudu namespace -- To view, visit http://gerrit.cloudera.org:8080/15005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e75a539c5de1c367d05784f544b96197249ec49 Gerrit-Change-Number: 15005 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 10 Jan 2020 18:13:31 +0000 Gerrit-HasComments: Yes
