Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15004 )
Change subject: clang-tidy: silence pragma-once-outside-header false positives ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15004/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15004/1//COMMIT_MSG@12 PS1, Line 12: caused by the '-x c++' flag provided > Ah, that's an interesting fact. Thank you for fixing this. Ack http://gerrit.cloudera.org:8080/#/c/15004/1//COMMIT_MSG@13 PS1, Line 13: files > drop Done http://gerrit.cloudera.org:8080/#/c/15004/1//COMMIT_MSG@31 PS1, Line 31: preprocessor definitions. The only remaining usage was YouCompleteMe, which > Nit: Missing a word? Done -- To view, visit http://gerrit.cloudera.org:8080/15004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If316344dc3c120ff278c9835b8a10aac49fab9b1 Gerrit-Change-Number: 15004 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 10 Jan 2020 18:53:44 +0000 Gerrit-HasComments: Yes
