Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15007 )
Change subject: time_manager: remove shared ownership ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15007/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/15007/2/src/kudu/tserver/tablet_service.cc@2436 PS2, Line 2436: s = HandleScanAtSnapshot( : scan_pb, rpc_context, projection, tablet.get(), replica->time_manager(), : &iter, &snap_start_timestamp, snap_timestamp, error_code); This first made me nervous because I wasn't sure we were guaranteed that the replica weren't deleted at this point. That said, I think it's indeed safe because even if we were to have deleted the table (and thus deleted the replica from our map in TSTabletManager), we'd still be hanging onto the TabletReplica reference and thus our RaftConsensus reference. -- To view, visit http://gerrit.cloudera.org:8080/15007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I871debdeaf5c8b92168e764b4a6142319f229438 Gerrit-Change-Number: 15007 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 10 Jan 2020 20:16:18 +0000 Gerrit-HasComments: Yes
