Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15010 )
Change subject: fs: remove test-only constructor ...................................................................... Patch Set 2: > 17:27:41 > /home/jenkins-slave/workspace/kudu-master/0/src/kudu/tablet/compaction-test.cc:445:17: > error: no matching constructor for initialization of 'kudu::FsManager' > 17:27:41 FsManager fs_manager(env_, FLAGS_merge_benchmark_input_dir); Yeah. What's odd is that this code was compiled out of DEBUG builds, but not ASAN/TSAN. DoBenchmark is only called in RELEASE builds. -- To view, visit http://gerrit.cloudera.org:8080/15010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11024a2f28123bba3e3989ddd5e68f581481d5fb Gerrit-Change-Number: 15010 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 11 Jan 2020 23:26:01 +0000 Gerrit-HasComments: No
