Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14426 )
Change subject: KUDU-2971 p2: add basic protobuf msg ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/14426/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14426/7//COMMIT_MSG@7 PS7, Line 7: KUDU-2971 > KUDU-2971 Done http://gerrit.cloudera.org:8080/#/c/14426/1/src/kudu/subprocess/subprocess.proto File src/kudu/subprocess/subprocess.proto: http://gerrit.cloudera.org:8080/#/c/14426/1/src/kudu/subprocess/subprocess.proto@34 PS1, Line 34: } > yeah but we use proto2 syntax, I thought proto3 would be necessary here. Ne Ack http://gerrit.cloudera.org:8080/#/c/14426/4/src/kudu/subprocess/subprocess.proto File src/kudu/subprocess/subprocess.proto: http://gerrit.cloudera.org:8080/#/c/14426/4/src/kudu/subprocess/subprocess.proto@17 PS4, Line 17: > nit: does it make sense to add a small comment pointing to the fact that th Done http://gerrit.cloudera.org:8080/#/c/14426/4/src/kudu/subprocess/subprocess.proto@25 PS4, Line 25: import "google/protobuf/any.proto"; : import "kudu/common/wire_protocol.proto"; : : // EchoResponsePB simply echoes the data in EchoRequestPB as a response. : message EchoRequestPB { : > Do you mind adding a small comment for these (something like in the commit Done -- To view, visit http://gerrit.cloudera.org:8080/14426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954 Gerrit-Change-Number: 14426 Gerrit-PatchSet: 8 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 13 Jan 2020 07:03:13 +0000 Gerrit-HasComments: Yes
