Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15048 )
Change subject: [tserver] replace gscoped_ptr with unique_ptr in Scanner ...................................................................... Patch Set 1: Verified+1 (2 comments) Unrelated test failures: * KUDU-2335 * KUDU-3043 IWYU failure seems weird seems on my CentOS6 build server it passes with no issues: 2020-01-16 09:31:15,410 INFO: Checking 3 file(s)... IWYU would have edited 0 files on your behalf. Built target iwyu ve0518:scanner-spec.debug[scanner-spec]$ http://gerrit.cloudera.org:8080/#/c/15048/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/15048/1/src/kudu/tserver/tablet_service.cc@2190 PS1, Line 2190: lower_bound = val; > warning: Assigned value is garbage or undefined [clang-analyzer-core.uninit I'm going to ignore this garbage warning since the 'val' cannot be assigned a garbage value: ExtractPredicateValue() returns OK only if assigning a valid value to its output parameter. http://gerrit.cloudera.org:8080/#/c/15048/1/src/kudu/tserver/tablet_service.cc@2197 PS1, Line 2197: upper_bound = val; > warning: Assigned value is garbage or undefined [clang-analyzer-core.uninit ditto -- To view, visit http://gerrit.cloudera.org:8080/15048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieac533565f96773cc450de521703c21534020596 Gerrit-Change-Number: 15048 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 16 Jan 2020 17:58:29 +0000 Gerrit-HasComments: Yes
