Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15036 )
Change subject: [client] support resolve one master address to multiple addresses ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/15036/3/java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java: http://gerrit.cloudera.org:8080/#/c/15036/3/java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java@104 PS3, Line 104: return getAllInetAddresses(host)[0]; Nit: Is a non-null but empty array a possibility? Better to check for that case as well. http://gerrit.cloudera.org:8080/#/c/15036/3/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/15036/3/src/kudu/client/client-internal.cc@687 PS3, Line 687: , and try to connect each to them. This needs rewording. ". Connecting to each one of them." http://gerrit.cloudera.org:8080/#/c/15036/3/src/kudu/util/net/sockaddr.h File src/kudu/util/net/sockaddr.h: http://gerrit.cloudera.org:8080/#/c/15036/3/src/kudu/util/net/sockaddr.h@80 PS3, Line 80: of "of" should be removed http://gerrit.cloudera.org:8080/#/c/15036/3/src/kudu/util/net/sockaddr.cc File src/kudu/util/net/sockaddr.cc: http://gerrit.cloudera.org:8080/#/c/15036/3/src/kudu/util/net/sockaddr.cc@136 PS3, Line 136: addrs.size() Bug: This'll initialize addrs_str with addrs.size() empty strings and then further add same number of more strings with push_back() in the loop below. I think you are looking for addrs_str.reserve(addrs.size()) instead. -- To view, visit http://gerrit.cloudera.org:8080/15036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie242bc1331596902fa16f1c6d1b439d78b73977a Gerrit-Change-Number: 15036 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Thu, 16 Jan 2020 18:01:09 +0000 Gerrit-HasComments: Yes
