Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15055 )
Change subject: [metrics] fix compilation on macOS ...................................................................... Patch Set 1: > Build Successful > > http://jenkins.kudu.apache.org/job/kudu-gerrit/20167/ : SUCCESS It's funny, but there are also various callbacks that also have size_t/uint64_t mixed, e.g. 'size_t TabletReplica::OnDiskSize()'. So, removing the custom instantiation for macOS breaks. Another alternative to fix the compilation breakage is making instances of atomic gauges like 'scoped_refptr<AtomicGauge<uint64_t>> tablet_active_scanners' to be of 'size_t' type. And yet another is going through mixed instantiations, replacing uint64_t with size_t, where appropriate. Just an extra option to those mentioned in 879cd9ab7e55f70c00851e45b6682870bab9f4b1. -- To view, visit http://gerrit.cloudera.org:8080/15055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e7109aebec268db1d545e657c991e7791f85210 Gerrit-Change-Number: 15055 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2020 23:07:44 +0000 Gerrit-HasComments: No
