Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15032 )
Change subject: KUDU-3042: Fix invalid DCHECK when rpc is cancelled then times out ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15032/2/src/kudu/rpc/rpc-test-base.h File src/kudu/rpc/rpc-test-base.h: http://gerrit.cloudera.org:8080/#/c/15032/2/src/kudu/rpc/rpc-test-base.h@536 PS2, Line 536: static void DoTestExpectTimeout(const Proxy& p, > warning: method 'DoTestExpectTimeout' can be made static [readability-conve Done http://gerrit.cloudera.org:8080/#/c/15032/2/src/kudu/rpc/rpc-test-base.h@558 PS2, Line 558: int elapsed_millis = static_cast<int>(sw.elapsed().wall_millis()); > warning: narrowing conversion from 'double' to 'int' [bugprone-narrowing-co Done -- To view, visit http://gerrit.cloudera.org:8080/15032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b97ccc4787809fca8fbc991bb1151940477efca Gerrit-Change-Number: 15032 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2020 23:15:31 +0000 Gerrit-HasComments: Yes
