Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15069 )
Change subject: mini-cluster: disallow restarting daemons from other threads ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15069/1/src/kudu/mini-cluster/external_mini_cluster.h File src/kudu/mini-cluster/external_mini_cluster.h: http://gerrit.cloudera.org:8080/#/c/15069/1/src/kudu/mini-cluster/external_mini_cluster.h@617 PS1, Line 617: std::thread::id parent_tid_; nit: add const? http://gerrit.cloudera.org:8080/#/c/15069/1/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/15069/1/src/kudu/mini-cluster/external_mini_cluster.cc@945 PS1, Line 945: parent_tid_ = std::this_thread::get_id(); nit: move to the initializer list? http://gerrit.cloudera.org:8080/#/c/15069/1/src/kudu/mini-cluster/external_mini_cluster.cc@975 PS1, Line 975: << "Process being started from thread " << this_tid << " which is different" : << " from the instantiating thread " << parent_tid_; nit: probably, Substitute() would provide better readability? -- To view, visit http://gerrit.cloudera.org:8080/15069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I184a01be3e1ac7f60a8b3aedab176dc9138033e0 Gerrit-Change-Number: 15069 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 18 Jan 2020 04:55:45 +0000 Gerrit-HasComments: Yes
