Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15101 )
Change subject: [util] add error buffer for EasyCurl wrapper ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15101/1/src/kudu/util/curl_util.h File src/kudu/util/curl_util.h: http://gerrit.cloudera.org:8080/#/c/15101/1/src/kudu/util/curl_util.h@24 PS1, Line 24: #include <curl/curl.h> Would be nice if we could avoid leaking this header to whomever includes curl_util.h. http://gerrit.cloudera.org:8080/#/c/15101/1/src/kudu/util/curl_util.cc File src/kudu/util/curl_util.cc: http://gerrit.cloudera.org:8080/#/c/15101/1/src/kudu/util/curl_util.cc@173 PS1, Line 173: if (strlen(errbuf_) != 0) { Maybe we can pass errbuf_ by arg and avoid exposing TranslateError as a member function? -- To view, visit http://gerrit.cloudera.org:8080/15101 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e4a8a8a42671f141842ff6051aa18820a8f7f5a Gerrit-Change-Number: 15101 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 24 Jan 2020 03:27:12 +0000 Gerrit-HasComments: Yes
