Grant Henke has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/15129 )
Change subject: [cmake_modules] fix GET_LINKER_VERSION on macOS Catalina
......................................................................
[cmake_modules] fix GET_LINKER_VERSION on macOS Catalina
On macOS Catalina the linker version is currently `530`.
The current regex requires a second version component.
The result is an error that looks like the following:
CMake Error at cmake_modules/KuduLinker.cmake:160 (message):
Could not extract ld64 version. Linker version output:
Call Stack (most recent call first):
cmake_modules/KuduLinker.cmake:36 (GET_LINKER_VERSION)
CMakeLists.txt:398 (APPEND_LINKER_FLAGS)
To fix this the regex was updated to make the second version
component optional.
Change-Id: I11b43153279cc44766f5f03c7d59808d555d9321
Reviewed-on: http://gerrit.cloudera.org:8080/15129
Reviewed-by: Alexey Serbin <[email protected]>
Tested-by: Kudu Jenkins
---
M cmake_modules/KuduLinker.cmake
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I11b43153279cc44766f5f03c7d59808d555d9321
Gerrit-Change-Number: 15129
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
