Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15121 )
Change subject: Add cloning support to BlockBloomFilter and associated allocator ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/15121/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15121/1//COMMIT_MSG@11 PS1, Line 11: Since cloning needs to be supported, DefaultBlockBloomFilterAllocator : is no longer a singleton. > Changed to returning unique_ptr What did you think about my other suggestion, to return shared_ptr, which would let you preserve the default allocator as a singleton? http://gerrit.cloudera.org:8080/#/c/15121/3/src/kudu/util/block_bloom_filter.cc File src/kudu/util/block_bloom_filter.cc: http://gerrit.cloudera.org:8080/#/c/15121/3/src/kudu/util/block_bloom_filter.cc@133 PS3, Line 133: std:: Nit: add a using for this. http://gerrit.cloudera.org:8080/#/c/15121/3/src/kudu/util/block_bloom_filter.cc@138 PS3, Line 138: if (!s.ok()) { : return nullptr; : } It's nice to preserve Statuses when we can, so I'd prefer if Clone returned the Status and passed the cloned object via OUT parameter. -- To view, visit http://gerrit.cloudera.org:8080/15121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74b24ce0959930a3ee7d5df77874e42be0b50b41 Gerrit-Change-Number: 15121 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 31 Jan 2020 23:23:25 +0000 Gerrit-HasComments: Yes
