Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15150 )
Change subject: [consensus] cleanup on TimeManager ...................................................................... [consensus] cleanup on TimeManager A tiny cleanup: * removed outdated TODO TimeManager::WaitUntilSafe() * removed questionable PREDICT_FALSE() and its extra 'if ()' scope I also thought of replacing std::vector with std::deque as the container for TimeManager::waiters_, but I'm not sure it's worth it given the expected number of elements in there. Change-Id: I1315e058b4a8e0518c96fad6454aeb4d0a46b2e6 Reviewed-on: http://gerrit.cloudera.org:8080/15150 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/consensus/time_manager.cc M src/kudu/consensus/time_manager.h 2 files changed, 9 insertions(+), 14 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15150 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1315e058b4a8e0518c96fad6454aeb4d0a46b2e6 Gerrit-Change-Number: 15150 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
