Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8134 )
Change subject: KUDU-2155: disable failure detector around elections ...................................................................... KUDU-2155: disable failure detector around elections This is a more complete fix for KUDU-2149 which disables the failure detector completely around a leader election. There are several changes to make this happen: 1. The FD is changed to use a one-shot timer, which automatically disables upon firing. 2. Because all elections are guaranteed to reach DoElectionCallback, that's where we reenable the FD. 3. We provide a special case for pre-elections where FD reenabling is deferred until after the subsequent real election finishes. I'm still not convinced this is the cleanest approach, but it seems to work. Change-Id: Idcd311cee028c48e908f290d60c474e8a4557d97 Reviewed-on: http://gerrit.cloudera.org:8080/8134 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h 2 files changed, 77 insertions(+), 61 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idcd311cee028c48e908f290d60c474e8a4557d97 Gerrit-Change-Number: 8134 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]>
