Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15166 )
Change subject: [util] Add a function to generate random unique 32-bit/64-bit integers ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/15166/1/src/kudu/util/random.h File src/kudu/util/random.h: http://gerrit.cloudera.org:8080/#/c/15166/1/src/kudu/util/random.h@124 PS1, Line 124: constexpr IntType GetNextRandom(Random* rand) { Can we also templatize this on Random vs. ThreadSafeRandom as is done in StdUniformRNG below? http://gerrit.cloudera.org:8080/#/c/15166/1/src/kudu/util/random_util-test.cc File src/kudu/util/random_util-test.cc: http://gerrit.cloudera.org:8080/#/c/15166/1/src/kudu/util/random_util-test.cc@84 PS1, Line 84: std::unordered_set<IntType> avoid; using here http://gerrit.cloudera.org:8080/#/c/15166/1/src/kudu/util/random_util.h File src/kudu/util/random_util.h: http://gerrit.cloudera.org:8080/#/c/15166/1/src/kudu/util/random_util.h@102 PS1, Line 102: Return Nit: Generates http://gerrit.cloudera.org:8080/#/c/15166/1/src/kudu/util/random_util.h@107 PS1, Line 107: Random* rand) { Can you templatize on RNG type? -- To view, visit http://gerrit.cloudera.org:8080/15166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I512cb649021802aa7595117ad6b29d3fb4a762b3 Gerrit-Change-Number: 15166 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 05 Feb 2020 23:01:50 +0000 Gerrit-HasComments: Yes
