Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15172 )
Change subject: [util] add CURLOPT_FAILONERROR for instance metadata requests ...................................................................... [util] add CURLOPT_FAILONERROR for instance metadata requests By default, libcurl doesn't return an error if the server responds with HTTP response >= 400. It makes sense for handling auth-related codes such as 401 and 407. In case of retrieving cloud instance metadata it's more convenient to turn HTTP response codes >= 400 into CURLcode errors. Change-Id: I10ca30b13323cdd4cad65259dda78e0ee3c7d647 Reviewed-on: http://gerrit.cloudera.org:8080/15172 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Alexey Serbin <[email protected]> --- M src/kudu/util/cloud/instance_metadata.cc M src/kudu/util/curl_util.cc M src/kudu/util/curl_util.h 3 files changed, 15 insertions(+), 0 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/15172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I10ca30b13323cdd4cad65259dda78e0ee3c7d647 Gerrit-Change-Number: 15172 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
