Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15171 )
Change subject: [clock] ntp_gettime(): STA_NANO bites again ...................................................................... Patch Set 1: (1 comment) > (1 comment) > > Would be nice to think about how we could test this. Seems hard > without mocking the results of whatever "get time" system call we > end up using. Well, at least we can try to run gettimeofday() along with ntp_gettime() and compare the results. I'll try to put together a patch with a test (separate changelist). http://gerrit.cloudera.org:8080/#/c/15171/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15171/1//COMMIT_MSG@9 PS1, Line 9: The issue fixed once in 10f6164b1217e0299bcfedc061d2c57581c389bd : was reintroduced again in e72208436. And this patch addresses it : once again. > So here's ntp_gettime() implementation in glibc: Done -- To view, visit http://gerrit.cloudera.org:8080/15171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id171b6fea2274d32a35c6173bab9996b36c0c4f6 Gerrit-Change-Number: 15171 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Thu, 06 Feb 2020 05:38:54 +0000 Gerrit-HasComments: Yes
