Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 )
Change subject: [java] KUDU-2971: process communicates via protobuf-based protocol ...................................................................... Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/14329/17/java/kudu-subprocess/build.gradle File java/kudu-subprocess/build.gradle: http://gerrit.cloudera.org:8080/#/c/14329/17/java/kudu-subprocess/build.gradle@46 PS17, Line 46: jar { : manifest { : attributes( : 'Main-Class': 'org.apache.kudu.subprocess.EchoSubprocessMain' : ) : } : } > Is it expected that this builds kudu-subprocess.jar and not some echo-subpr Yeah, EchoSubprocessMain is the default protocol supported for kudu-subprocess. But if it sounds confusing, I can rename it DefaultSubprocessMain? Which on the other hand lost the track of what protocol it is supporting. http://gerrit.cloudera.org:8080/#/c/14329/17/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/MessageWriter.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/MessageWriter.java: http://gerrit.cloudera.org:8080/#/c/14329/17/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/MessageWriter.java@43 PS17, Line 43: private static final Logger LOG = LoggerFactory.getLogger(MessageWriter.class); > Not sure if you're seeing this, but when I run the subprocess from a C++-ma Hmm, I think I saw this as well with C++ patch, it seems somehow the logger isn't picked up. Haven't figured it out why, I am planning to address it with the follow up patch (with C++). -- To view, visit http://gerrit.cloudera.org:8080/14329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf9ad24dbc9acc681284b6433836271b5b4c7982 Gerrit-Change-Number: 14329 Gerrit-PatchSet: 17 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 06 Feb 2020 20:12:15 +0000 Gerrit-HasComments: Yes
