Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15197 )
Change subject: KUDU-2996: trace when rpc_duration_too_long_ms exceeded ...................................................................... Patch Set 1: (1 comment) Also fixed the IWYU error http://gerrit.cloudera.org:8080/#/c/15197/1/src/kudu/rpc/rpcz_store.cc File src/kudu/rpc/rpcz_store.cc: http://gerrit.cloudera.org:8080/#/c/15197/1/src/kudu/rpc/rpcz_store.cc@270 PS1, Line 270: << "Request Metrics: " << call->trace()->MetricsAsJSON() << "\n"; > If we are dumping both time deltas and metrics below, why do we need to dup I went with the first option. I should've looked more closely at what the functions did - I didn't realise the trace included the metrics. -- To view, visit http://gerrit.cloudera.org:8080/15197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20d9b5e318f4a987051f1f7c2cd5b1d92c61bd05 Gerrit-Change-Number: 15197 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 10 Feb 2020 19:09:20 +0000 Gerrit-HasComments: Yes
