Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15200 )
Change subject: [util] link kudu_util_compression into some tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15200/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15200/1//COMMIT_MSG@20 PS1, Line 20: This patch addresses the issue, adding kudu_util_compression into the : list of linked in libraries for those binaries. Surprisingly, adding : just zlib was not enough, but I decided not to fuss around that. Seems like what the error message is telling us is that libcurl depends on inflateInit2_, which is defined in libz. So shouldn't we add zlib to curl's DEPS in the ADD_THIRDPARTY_LIB call CMakeLists.txt, as was done for glog (depends on unwind) or protoc (depends on protobuf)? -- To view, visit http://gerrit.cloudera.org:8080/15200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76ed772845a7e7a00b0ee023dfac51595af383ca Gerrit-Change-Number: 15200 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 10 Feb 2020 22:28:55 +0000 Gerrit-HasComments: Yes
