Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15204 )

Change subject: [examples] Add a quickstart guide for YCSB
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15204/2/examples/quickstart/ycsb/README.adoc
File examples/quickstart/ycsb/README.adoc:

http://gerrit.cloudera.org:8080/#/c/15204/2/examples/quickstart/ycsb/README.adoc@30
PS2, Line 30:
> Maybe, add another option to build Kudu from source and then use $KUDU_ROOT
These guides under the quickstart directory are targeted at the quickstart 
cluster. I fully expect users to run YCSB against other types of clusters too 
which is why I put the "NOTE" above.


http://gerrit.cloudera.org:8080/#/c/15204/2/examples/quickstart/ycsb/README.adoc@38
PS2, Line 38: -O --location
> nit: maybe, use the same option notation for both flags?  I.e., either '-LO
Done


http://gerrit.cloudera.org:8080/#/c/15204/2/examples/quickstart/ycsb/README.adoc@39
PS2, Line 39: xfvz
> nit: xfv (drop 'z' since it's not needed here)
Done



--
To view, visit http://gerrit.cloudera.org:8080/15204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26255c9389a8bb59af1009cd67f720149e59f4a1
Gerrit-Change-Number: 15204
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Feb 2020 18:54:05 +0000
Gerrit-HasComments: Yes

Reply via email to