Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15176 )

Change subject: KUDU-3049: [spark] Automatic handling of schema drift
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15176/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
File 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala:

http://gerrit.cloudera.org:8080/#/c/15176/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@357
PS3, Line 357: e.getMessage.contains("column already exists")
Relying on the error message making this brittle.  Is it possible to use status 
instead, something like:

  Status exStatus = e.getStatus();
  if (exStatus.isAlreadyPresent()) {
    ...
  }



--
To view, visit http://gerrit.cloudera.org:8080/15176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1edebb293d6ae79c26a0ecb9ce7755308f667f4
Gerrit-Change-Number: 15176
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Feb 2020 19:53:31 +0000
Gerrit-HasComments: Yes

Reply via email to