Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15209 )
Change subject: [clock] small cleanup on built-in NTP client flags ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15209/1/src/kudu/clock/builtin_ntp.cc File src/kudu/clock/builtin_ntp.cc: http://gerrit.cloudera.org:8080/#/c/15209/1/src/kudu/clock/builtin_ntp.cc@113 PS1, Line 113: the don't need http://gerrit.cloudera.org:8080/#/c/15209/1/src/kudu/clock/builtin_ntp.cc@115 PS1, Line 115: This flag is " : "gated by setting --time_source=builtin (i.e. it does not affect " : "anything if --time_source is not set to 'builtin'). I don't think this is necessary, and it's especially confusing given that it may also take effect if the time source is 'auto'. -- To view, visit http://gerrit.cloudera.org:8080/15209 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa419013f047d8ec7803092f8225199e9e6f985b Gerrit-Change-Number: 15209 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 12 Feb 2020 00:55:48 +0000 Gerrit-HasComments: Yes
