Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15212 )
Change subject: [hybrid clock] KUDU-3048 introduce new clock metrics ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15212/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15212/1//COMMIT_MSG@12 PS1, Line 12: when when double when http://gerrit.cloudera.org:8080/#/c/15212/1/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/15212/1/src/kudu/clock/hybrid_clock.cc@131 PS1, Line 131: METRIC_DEFINE_gauge_uint64(server, hybrid_clock_max_error, Likewise, if you use a histogram you'll get min, avg, and percentiles too. http://gerrit.cloudera.org:8080/#/c/15212/1/src/kudu/clock/hybrid_clock.cc@136 PS1, Line 136: METRIC_DEFINE_gauge_int64(server, hybrid_clock_longest_extrapolation_interval, : "Longest Interval of Hybrid Clock Extrapolation", : kudu::MetricUnit::kMicroseconds, : "Longest interval when the underlying clock was " : "extrapolated instead of directly reading it", : kudu::MetricLevel::kWarn); This and extrapolation_intervals seem like a great fit for a single histogram metric. -- To view, visit http://gerrit.cloudera.org:8080/15212 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8575ba7d8baed78b13351e8cebf1a74f44b31b82 Gerrit-Change-Number: 15212 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 12 Feb 2020 21:32:33 +0000 Gerrit-HasComments: Yes
