Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15224 )
Change subject: [test] fix flake in TsTabletManagerITest::TestTableStats ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/15224/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/15224/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc@820 PS3, Line 820: auto s = LeaderStepDown(tserver, replica->tablet_id(), I wonder how pervasive this issue is amongst our tests. Seems like every ASSERT_OK(LeaderStepDown(current_leader, ...)) could be flaky if it's not wrapped in an ASSERT_EVENTUALLY or if it doesn't otherwise allow for the possibility that leadership changed in between when current_leader was populated and now. http://gerrit.cloudera.org:8080/#/c/15224/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc@826 PS3, Line 826: anymor anymore http://gerrit.cloudera.org:8080/#/c/15224/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc@829 PS3, Line 829: } Do you want to ASSERT_OK(s) after this if statement? And do you still want to sleep after the call? -- To view, visit http://gerrit.cloudera.org:8080/15224 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbd6652cdcb30f8899767dfb932cc402cf739115 Gerrit-Change-Number: 15224 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 14 Feb 2020 21:28:06 +0000 Gerrit-HasComments: Yes
