Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/15212 )
Change subject: [hybrid clock] KUDU-3048 introduce new clock metrics
......................................................................
[hybrid clock] KUDU-3048 introduce new clock metrics
Introduced additional metrics for the hybrid clock:
* whether hybrid clock is using extrapolated readings for the
underlying clock instead of actual readings
* histogram for the duration of intervals when the underlying clock
was extrapolated
* histogram for the maximum errors reported by the underlying clock
I ran a small Kudu cluster to manually verify the behavior of the
newly introduced metrics: I'm not sure it's worth adding automated
tests for this given the already existing 'hybrid_clock_error' metric
didn't have any test coverage.
Change-Id: I8575ba7d8baed78b13351e8cebf1a74f44b31b82
Reviewed-on: http://gerrit.cloudera.org:8080/15212
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <[email protected]>
---
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/hybrid_clock.h
M src/kudu/server/server_base.cc
M src/kudu/util/metrics.cc
4 files changed, 75 insertions(+), 17 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8575ba7d8baed78b13351e8cebf1a74f44b31b82
Gerrit-Change-Number: 15212
Gerrit-PatchSet: 8
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <[email protected]>
