Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15207 )
Change subject: [WIP] Ranger authorization provider ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/15207/5/src/kudu/master/ranger_authz_provider.h File src/kudu/master/ranger_authz_provider.h: http://gerrit.cloudera.org:8080/#/c/15207/5/src/kudu/master/ranger_authz_provider.h@37 PS5, Line 37: class RangerAuthzProvider : public AuthzProvider { > The public methods in this class should be marked 'override'. Done http://gerrit.cloudera.org:8080/#/c/15207/5/src/kudu/master/ranger_authz_provider.h@46 PS5, Line 46: : // Returns Status::NotSupported() as Ranger authz provider doesn't support : // resetting its cache. : Status ResetC > These comments should be updated to reflect the RangerAuthzProvider's seman Done http://gerrit.cloudera.org:8080/#/c/15207/5/src/kudu/master/ranger_authz_provider.cc File src/kudu/master/ranger_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/15207/5/src/kudu/master/ranger_authz_provider.cc@120 PS5, Line 120: Status RangerAuthzProvider::AuthorizeGetTableStatistics(const string& tabl > It's probably worth validating that the Ranger client will cache privileges I'm not sure what you mean, do you mean the C++ Ranger client should cache privileges? The Ranger plugin caches privileges automatically and it shouldn't be much overhead calling the subprocess as it's all stdio. http://gerrit.cloudera.org:8080/#/c/15207/5/src/kudu/master/ranger_authz_provider.cc@152 PS5, Line 152: if (client_.AuthorizeAction(user, Act > nit: could use EmplaceOrDie here changed column_names to vector in the meantime. http://gerrit.cloudera.org:8080/#/c/15207/5/src/kudu/master/ranger_authz_provider.cc@157 PS5, Line 157: > nit: use InsertOrDie or EmplaceOrDie? The column IDs should never already b I think so, I copied this part from the Sentry authz provider actually. -- To view, visit http://gerrit.cloudera.org:8080/15207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e7672a5947d6406e0cad83a0c900bf5b2c03012 Gerrit-Change-Number: 15207 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 17 Feb 2020 07:32:42 +0000 Gerrit-HasComments: Yes
