Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/4522 )
Change subject: [python] KUDU-1563. Add support for INSERT_IGNORE ...................................................................... Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/4522/20/python/kudu/client.pyx File python/kudu/client.pyx: http://gerrit.cloudera.org:8080/#/c/4522/20/python/kudu/client.pyx@846 PS20, Line 846: def new_insert_ignore(self, record): Should we allow record to be None as for the other new_*** functions? http://gerrit.cloudera.org:8080/#/c/4522/20/python/kudu/client.pyx@848 PS20, Line 848: Create a new Insert Ignore operation. Pass the completed Insert Ignore to a Session. Seems like there's more docs that can be cribbed from the other new_*** functions. -- To view, visit http://gerrit.cloudera.org:8080/4522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79 Gerrit-Change-Number: 4522 Gerrit-PatchSet: 20 Gerrit-Owner: Brock Noland <br...@phdata.io> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Brock Noland <br...@phdata.io> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jtbirds...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 18 Feb 2020 02:21:32 +0000 Gerrit-HasComments: Yes
