Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15074 )
Change subject: [java] KUDU-2972: add Kudu Ranger plugin ...................................................................... Patch Set 6: > > How do you feel about predicating this change on MiniRanger support? The > > mock-based testing is good, but as it stands we lack any coverage that the > > Ranger plugin internals themselves are working given our input. > > Yeah, I think it will be great if we can enable MiniRanger for Java testing > as well. However as Ranger admin server requires external database config > (e.g. postgres, mysql), it seems hard for Java test to have a proper setup > for MiniRanger. On the other hand, we will have MiniRanger support in C++ > which should have enough coverage from end-to-end (although again it would be > better to have MiniRanger test coverage in Java). Right, I didn't mean to suggest that Java tests should be controlling MiniRanger directly; rather that they'd interact with an external mini cluster (via the control shell protocol) as usual, and the cluster would include a MiniRanger. And, in the context of this patch, whether we should hit pause on it and go work on MiniRanger support, so that we can actually show end-to-end coverage on this patch before merging it. BTW, are you saying it won't be possible to deploy a MiniRanger _without_ an RDBMS? Or can Ranger support simple file-based databases like sqlite or Derby? Setting up a full-fledged RDBMS is a huge pain, and I'm not even sure whether it's possible to do it without root. -- To view, visit http://gerrit.cloudera.org:8080/15074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c995ac1a48ebf57667231cd3a82d3794f6ddf8d Gerrit-Change-Number: 15074 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 18 Feb 2020 18:19:29 +0000 Gerrit-HasComments: No
