Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15270 )
Change subject: [subprocess] use a CountDownLatch ...................................................................... [subprocess] use a CountDownLatch As follow-up to 20be5d957ab80c7c0ed8eaf62324ac70940d7543, this converts the atomic boolean that signals a shutdown in the SubprocessServer to a CountDownLatch. This allows us to combine some of the sleeps with the shutdown checks. To do this, I had to update the CountDownLatch::CountDown() methods to return whether they actually counted down. Change-Id: I1adfdf3a9ccb6e8ee8c60cfab68562dde3e642d6 Reviewed-on: http://gerrit.cloudera.org:8080/15270 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/subprocess/server.cc M src/kudu/subprocess/server.h M src/kudu/util/countdown_latch.h 3 files changed, 26 insertions(+), 22 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1adfdf3a9ccb6e8ee8c60cfab68562dde3e642d6 Gerrit-Change-Number: 15270 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
