Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15271 )
Change subject: [util] move PeriodWebUIChecker into a separate header file ...................................................................... Patch Set 1: (2 comments) > (2 comments) > > Looks like the TSAN build failed because the Gradle daemon died > unexpectedly. Please ask Hao and/or Andrew to debug it further. Yup, I'm planning to bug them on Monday. http://gerrit.cloudera.org:8080/#/c/15271/1/src/kudu/util/webui_checker.h File src/kudu/util/webui_checker.h: PS1: > In a follow-up, could you move some of the logic into a new .cc file too? Done http://gerrit.cloudera.org:8080/#/c/15271/1/src/kudu/util/webui_checker.h@29 PS1, Line 29: #include "kudu/client/client.h" > The dependencies on client and mini-cluster modules suggest that util/ isn' Indeed. In fact, many of these header files are not needed. I removed them. Eventually, what's left is the dependency on ExternalMiniCluster. I could be replaced with a couple of arrays containing HostPort elements for the bound web server addresses, but I think keeping that dependency and moving this under mini_cluster is good enough. -- To view, visit http://gerrit.cloudera.org:8080/15271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e6c8e0ebe9e5d03ddf010ea225414af5823becc Gerrit-Change-Number: 15271 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Mon, 24 Feb 2020 07:15:30 +0000 Gerrit-HasComments: Yes
