Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15273 )
Change subject: [clock] safer handling of metrics-related endpoints ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/15273/1/src/kudu/clock/hybrid_clock-test.cc File src/kudu/clock/hybrid_clock-test.cc: http://gerrit.cloudera.org:8080/#/c/15273/1/src/kudu/clock/hybrid_clock-test.cc@401 PS1, Line 401: ASSERT_FALSE(ntp_servers.empty()); > Maybe ASSERT_EQ(1, ntp_servers.size()) instead? Done http://gerrit.cloudera.org:8080/#/c/15273/1/src/kudu/clock/hybrid_clock-test.cc@427 PS1, Line 427: presense > presence Done http://gerrit.cloudera.org:8080/#/c/15273/1/src/kudu/clock/hybrid_clock.h File src/kudu/clock/hybrid_clock.h: http://gerrit.cloudera.org:8080/#/c/15273/1/src/kudu/clock/hybrid_clock.h@218 PS1, Line 218: that requires 'lock_' to be held already > This doesn't appear to be true in the code. Whoops, good catch -- it seems the plan has changed at some point, and this comment left stale. Fixed. http://gerrit.cloudera.org:8080/#/c/15273/1/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/15273/1/src/kudu/clock/hybrid_clock.cc@585 PS1, Line 585: object > the hybrid clock Done http://gerrit.cloudera.org:8080/#/c/15273/1/src/kudu/clock/hybrid_clock.cc@587 PS1, Line 587: // when the object is not ready for that yet. > Maybe be more explicit about what happens? Some sort of crash or inconsiste Well, it changed: it used to crash before this change, now metrics are set to some special values. The point is that there is no value in reported metrics anyways. I added a comment. -- To view, visit http://gerrit.cloudera.org:8080/15273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic172635a7c7b019e5f4394c6107345820d408a68 Gerrit-Change-Number: 15273 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Mon, 24 Feb 2020 08:19:23 +0000 Gerrit-HasComments: Yes
