Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15286 )
Change subject: [webserver] HtmlOutputSchemaTable() is gone ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15286/1/src/kudu/server/webui_util.h File src/kudu/server/webui_util.h: http://gerrit.cloudera.org:8080/#/c/15286/1/src/kudu/server/webui_util.h@a37 PS1, Line 37: > Q: I'd expect compiler/linker to complain with definition missing but I gue Yup, it seems so. Probably, there is a way to configure clang-tidy to warn about this type of things -- I'll take a closer look. -- To view, visit http://gerrit.cloudera.org:8080/15286 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee0e57d667c79dd749758e202dccce8364c68c54 Gerrit-Change-Number: 15286 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2020 00:51:28 +0000 Gerrit-HasComments: Yes
