Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 )
Change subject: KUDU-2780: create thread for auto-rebalancing ...................................................................... Patch Set 17: (3 comments) http://gerrit.cloudera.org:8080/#/c/14177/17/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/14177/17/src/kudu/master/auto_rebalancer.cc@501 PS17, Line 501: TSDescriptorVector descriptors; : ts_manager_->GetDescriptorsAvailableForPlacement(&descriptors); : if (descriptors.size() != ts_manager_->GetLiveCount()) { : return Status::IllegalState(Substitute("not all tservers available for tablet placement")); : } > The TSManager only knows about tablet servers that have heartbeated recentl I think this is verified at L600? The uuids of tservers available for placement (according to the TSManager) are put into tserver_uuids. The ReplicaSummary's rep.ts_uuid is filled with the TSInfoPB returned by a call to CatalogManager::GetTabletLocations(). If the replica is known by the catalog manager but isn't known by the TSManager, this check should fail: if (!ContainsKey(tserver_uuids, rep.ts_uuid)) { return Status::NotFound(Substitute("tserver $0 not available for placement", rep.ts_uuid)); } http://gerrit.cloudera.org:8080/#/c/14177/17/src/kudu/master/auto_rebalancer.cc@526 PS17, Line 526: RETURN_NOT_OK(catalog_manager_->GetAllTables(&table_infos)); > Right, but leadership can change in between the taking of this lock, e.g. i Done http://gerrit.cloudera.org:8080/#/c/14177/17/src/kudu/master/auto_rebalancer.cc@570 PS17, Line 570: // Consensus state information is the same for all replicas of this tablet. > Yeah we probably shouldn't, if it really isn't used. Done -- To view, visit http://gerrit.cloudera.org:8080/14177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifca25d1063c07047cf2123e6792b3c7395be20e4 Gerrit-Change-Number: 14177 Gerrit-PatchSet: 17 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 25 Feb 2020 07:58:23 +0000 Gerrit-HasComments: Yes
