Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15292 )
Change subject: [webserver] add information on time source ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15292/2//COMMIT_MSG Commit Message: PS2: I implemented storing/retrieving of the effective settings for time source-related parameters using defaults for corresponding gflags. Yes, it looks hacky but I'm not sure it's worth creating extra methods for this in HybridClock itself and exposing necessary knobs for the HybridClock instance to the web server. I'm open to change this approach (and maybe, even exposing that information to be available via RPC making corresponding changes in ServerStatusPB/server_base.proto) if it doesn't seem good enough. -- To view, visit http://gerrit.cloudera.org:8080/15292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ff07808a1a534f3546e88ff13bc876b98afdb7e Gerrit-Change-Number: 15292 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2020 23:16:56 +0000 Gerrit-HasComments: Yes
