Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15303 )
Change subject: [thirdparty] Update cmake to 3.16.4 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15303/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15303/1//COMMIT_MSG@11 PS1, Line 11: Boost 1.53 found. : Found Boost components: : system;thread;unit_test_framework;filesystem;chrono;program_options : CMake Error in /Users/mpercy/src/kudu/thirdparty/installed/common/share/cmake-3.9/Modules/FindBoost.cmake: : cmake_policy PUSH without matching POP : Call Stack (most recent call first): : build/cmake/DefineOptions.cmake:117 (find_package) : CMakeLists.txt:52 (include) This shouldn't be happening. Here's the related code in Thrift's DefineOptions.cmake: if(BUILD_CPP) set(boost_components) if(WITH_BOOSTTHREADS OR BUILD_TESTING) list(APPEND boost_components system thread) endif() if(BUILD_TESTING) list(APPEND boost_components unit_test_framework filesystem chrono program_options) endif() if(boost_components) find_package(Boost 1.53 REQUIRED COMPONENTS ${boost_components}) endif() elseif(BUILD_C_GLIB AND BUILD_TESTING) find_package(Boost 1.53 REQUIRED) endif() And here's how we build Thrift: # Thrift depends on bison. # # Configure for a very minimal install - only the C++ client libraries are needed. # Thrift requires C++11 when compiled on Linux against libc++ (see cxxfunctional.h). CFLAGS="$EXTRA_CFLAGS" \ CXXFLAGS="$EXTRA_CXXFLAGS -std=c++11" \ LDFLAGS="$EXTRA_LDFLAGS" \ LIBS="$EXTRA_LIBS" \ cmake \ -DBOOST_ROOT=$PREFIX \ -DBUILD_C_GLIB=OFF \ -DBUILD_COMPILER=ON \ -DBUILD_CPP=ON \ -DBUILD_EXAMPLES=OFF \ -DBUILD_HASKELL=OFF \ -DBUILD_JAVA=OFF \ -DBUILD_PYTHON=OFF \ -DBUILD_TESTING=OFF \ -DBUILD_TUTORIALS=OFF \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_INSTALL_PREFIX=$PREFIX \ -DWITH_BOOSTTHREADS=OFF \ -DWITH_LIBEVENT=OFF \ -DWITH_OPENSSL=OFF \ -DWITH_PLUGIN=OFF \ $EXTRA_CMAKE_FLAGS \ $THRIFT_SOURCE So BUILD_CPP is ON, but WITH_BOOSTTHREADS and BUILD_TESTING are both OFF. Meaning, Thrift shouldn't be trying to build Boost at all, which makes sense, because the components in your build log aren't even provided by the Boost built by Kudu in thirdparty. You should dig into the Thrift build log further to try to understand why it's attempting to build Boost. -- To view, visit http://gerrit.cloudera.org:8080/15303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c3c578aea0f45c1279302eedef2dc5a1f8e9e1 Gerrit-Change-Number: 15303 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 27 Feb 2020 04:51:28 +0000 Gerrit-HasComments: Yes
