Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15311 )

Change subject: [cmake] enable building with Java 11
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15311/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15311/1//COMMIT_MSG@11
PS1, Line 11: So, as of now
            : cmake fails if building with Java 11 JDK.
> Can you ask Grant about this? I thought he built all of Kudu in a Java 11 e
Added Grant into the list of reviewers.

>From the other side, after successfully building with OpenJDK11 and posting 
>this patch I realized we use add_jar() while building the HMS plugin, so 
>probably we cannot say we need only JRE for the build (i.e. I assume javac 
>should be there to build the Java code of the plugin).



--
To view, visit http://gerrit.cloudera.org:8080/15311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45d52665db0ce6394c976217f77b30b772a5de9e
Gerrit-Change-Number: 15311
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 27 Feb 2020 23:51:55 +0000
Gerrit-HasComments: Yes

Reply via email to