Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15206 )
Change subject: KUDU-2972 Add Ranger client ...................................................................... Patch Set 15: (6 comments) http://gerrit.cloudera.org:8080/#/c/15206/13/src/kudu/ranger/ranger_client-test.cc File src/kudu/ranger/ranger_client-test.cc: http://gerrit.cloudera.org:8080/#/c/15206/13/src/kudu/ranger/ranger_client-test.cc@65 PS13, Line 65: > warning: the parameter 'action' is copied for each invocation but only used Done http://gerrit.cloudera.org:8080/#/c/15206/13/src/kudu/ranger/ranger_client-test.cc@88 PS13, Line 88: using std::make_shared; > warning: using decl 'vector' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/15206/13/src/kudu/ranger/ranger_client-test.cc@145 PS13, Line 145: } > warning: parameter 'user_name' is passed by value and only copied once; con Done http://gerrit.cloudera.org:8080/#/c/15206/13/src/kudu/ranger/ranger_client-test.cc@147 PS13, Line 147: void Allow(string user_name, ActionPB action, string database_name, > warning: parameter 'database_name' is passed by value and only copied once; Done http://gerrit.cloudera.org:8080/#/c/15206/13/src/kudu/ranger/ranger_client-test.cc@148 PS13, Line 148: string table_name, string column_name = "") { > warning: parameter 'table_name' is passed by value and only copied once; co Done http://gerrit.cloudera.org:8080/#/c/15206/13/src/kudu/ranger/ranger_client-test.cc@149 PS13, Line 149: AuthorizedAction authorized_action; > warning: parameter 'column_name' is passed by value and only copied once; c Done -- To view, visit http://gerrit.cloudera.org:8080/15206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2e1ec19ed3aeb4d82ad38fe1fb655f57021c1a4 Gerrit-Change-Number: 15206 Gerrit-PatchSet: 15 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 02 Mar 2020 21:31:43 +0000 Gerrit-HasComments: Yes
