Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15206 )
Change subject: KUDU-2972 Add Ranger client ...................................................................... Patch Set 20: (4 comments) http://gerrit.cloudera.org:8080/#/c/15206/19/src/kudu/ranger/ranger.proto File src/kudu/ranger/ranger.proto: http://gerrit.cloudera.org:8080/#/c/15206/19/src/kudu/ranger/ranger.proto@33 PS19, Line 33: SELECT = 0; : INSERT = 1; : UPDATE = 2; : DELETE = 3; : ALTER = 4; : CREATE = 5; : DROP = 6; > nit: I think this can be removed now, and it is not quite accurate. Done http://gerrit.cloudera.org:8080/#/c/15206/12/src/kudu/ranger/ranger_client-test.cc File src/kudu/ranger/ranger_client-test.cc: http://gerrit.cloudera.org:8080/#/c/15206/12/src/kudu/ranger/ranger_client-test.cc@55 PS12, Line 55: string database_name; > hm SubprocessServer has an atomic member (next_id_) so it's not copy/move c never mind, refactored the test code a bit, no need to either copy/move construct the SubprocessServer now when using unique_ptr. http://gerrit.cloudera.org:8080/#/c/15206/16/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15206/16/src/kudu/ranger/ranger_client.cc@55 PS16, Line 55: ing std::string; > A little surprised to see it is set in ranger authz provider as Ranger clie hm makes sense, updated. http://gerrit.cloudera.org:8080/#/c/15206/19/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15206/19/src/kudu/ranger/ranger_client.cc@82 PS19, Line 82: > Maybe also advise the user to update the table name via table rename tool? Done -- To view, visit http://gerrit.cloudera.org:8080/15206 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2e1ec19ed3aeb4d82ad38fe1fb655f57021c1a4 Gerrit-Change-Number: 15206 Gerrit-PatchSet: 20 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 03 Mar 2020 20:38:15 +0000 Gerrit-HasComments: Yes
