Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15361 )
Change subject: [build] Fix Netty errors in verify_jars.pl ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15361/1/build-support/verify_jars.pl File build-support/verify_jars.pl: http://gerrit.cloudera.org:8080/#/c/15361/1/build-support/verify_jars.pl@31 PS1, Line 31: so|swp > Netty includes some libraries in META_INF for native epoll and kqueue. Nett Thanks. For some reason I though we use this for verification of JARs we build for mini-cluster as well, but it's not the case it seems. I downloaded netty-all-4.1.44.Final.jar from https://mvnrepository.com/artifact/io.netty/netty-all/4.1.44.Final and I don't see any '.dylib' files in there, indeed. But I also don't see '.swp' files in there. Interesting. Anyways, if you have a JAR with '.swp' files and it's indeed a part of the archive, probably it's something useful. -- To view, visit http://gerrit.cloudera.org:8080/15361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I335119057e0665f09134e526396c4c2080ec4285 Gerrit-Change-Number: 15361 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 04 Mar 2020 19:20:16 +0000 Gerrit-HasComments: Yes
