Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15207 )
Change subject: KUDU-2972 Add Ranger authorization provider ...................................................................... Patch Set 28: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/15207/28/src/kudu/master/ranger_authz_provider.h File src/kudu/master/ranger_authz_provider.h: http://gerrit.cloudera.org:8080/#/c/15207/28/src/kudu/master/ranger_authz_provider.h@87 PS28, Line 87: std::unordered_set<std::string> trusted_users_; Don't need this since we're inheriting IsTrustedUser() from the base class. http://gerrit.cloudera.org:8080/#/c/15207/28/src/kudu/master/ranger_authz_provider.cc File src/kudu/master/ranger_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/15207/28/src/kudu/master/ranger_authz_provider.cc@31 PS28, Line 31: : namespace kudu { : class MetricEntity; : } // namespace kudu nit: can move this into the kudu namespace below -- To view, visit http://gerrit.cloudera.org:8080/15207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e7672a5947d6406e0cad83a0c900bf5b2c03012 Gerrit-Change-Number: 15207 Gerrit-PatchSet: 28 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 05 Mar 2020 22:14:48 +0000 Gerrit-HasComments: Yes
