Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15375 )
Change subject: subprocess: add server metric for queue size ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15375/1/src/kudu/util/blocking_queue.h File src/kudu/util/blocking_queue.h: http://gerrit.cloudera.org:8080/#/c/15375/1/src/kudu/util/blocking_queue.h@277 PS1, Line 277: size_t max_size_; Could you declare this const? -- To view, visit http://gerrit.cloudera.org:8080/15375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62d2d5727dca3f54b59ff1044431326cbdde855d Gerrit-Change-Number: 15375 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 06 Mar 2020 01:08:25 +0000 Gerrit-HasComments: Yes
