Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15386 )
Change subject: master: plumb metric for master leadership ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15386/1/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/15386/1/src/kudu/master/sys_catalog.cc@408 PS1, Line 408: master_->num_raft_leaders(), > Huh. If this was so simple, why didn't we do it earlier? Yeah, I think when I first wrote the TODO, the plumbing wasn't as straightforward (eg it might've been in the tserver instead of kserver, and the comment here was counting on the move). -- To view, visit http://gerrit.cloudera.org:8080/15386 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6972a1b9f803e3e4f293c67b035f5e924c67df2 Gerrit-Change-Number: 15386 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 08 Mar 2020 22:55:59 +0000 Gerrit-HasComments: Yes
